Buttons block: Support default button variation in template and default block#53786
Draft
stokesman wants to merge 2 commits into
Draft
Buttons block: Support default button variation in template and default block#53786stokesman wants to merge 2 commits into
stokesman wants to merge 2 commits into
Conversation
|
Size Change: +40 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #53517 the lack of respect for default style variations in the Buttons block.
Why?
Default block variations ought to be respected.
How?
Reads the default block variation from the block editor store and applies said variation’s attributes to the inner blocks template and the default block.
Testing Instructions
…soon
Testing Instructions for Keyboard
Screenshots or screencast