ProgressBar: Add default tabIndex to make focusable#53383
Closed
tyxla wants to merge 4 commits into
Closed
Conversation
5 tasks
mirka
reviewed
Aug 9, 2023
mirka
left a comment
Member
There was a problem hiding this comment.
I believe what we're looking for (at least in the loading screen use case in #53032) is to associate the progress with the loading region.
I don't think <progress> elements are intended to ever be focusable, since they're not interactive.
alexstine
reviewed
Aug 10, 2023
alexstine
left a comment
Contributor
There was a problem hiding this comment.
Sorry for causing a waste of time here. Turns out, the component has correct markup after the MDN example and no further work should be done to it.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress
I'll head back over to the other PR to continue discussion.
Member
Author
|
Thanks for the info, @alexstine and @mirka 🙌 I'm happy to follow up on improving the component if anything occurs in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the
ProgressBarcomponent to make it focusable.cc @alexstine @andrewhayward for accessibility feedback.
Why?
While working on #53032 I noticed that the underlying
progresselement is not focusable and that makes it inaccessible. That meant we have to make it focusable so users with screen readers will be able to focus it and get it announced properly.How?
This PR adds a default
tabIndexof0to the underlyingprogressHTML element to make it focusable. We still allow the component user to override the value if they wish.I'm also adding a unit test to verify the focusing works as expected. You can try removing the
tabIndexand you should see the new test failing.Testing Instructions
npm run storybook:dev, load http://localhost:50240/?path=/story/components-experimental-progressbar--defaultTesting Instructions for Keyboard
Whether in the site editor or in Storybook, the element should be the sole focusable element in the canvas, so tabbing once should be enough.
Screenshots or screencast
None.