Merged
Conversation
Yesterday I merged a fix to the IconButton component which adds a `text-indent` for when the component has text. This works because the SVG inside is not affected by text-indent. But the quick-shortcuts in the block appender wrap this icon with a `span`, which _is_ affected by the text-indent. I can look for other solutions that do not rely on text-indent, but simply removing this span entirely seems to have no negative effects. Why was it added? No CSS appears to target the element.
youknowriad
reviewed
Mar 1, 2018
| onClick={ () => onInsert( item ) } | ||
| label={ sprintf( __( 'Add %s' ), item.title ) } | ||
| icon={ ( | ||
| <span className="editor-inserter-with-shortcuts__block-icon"> |
Contributor
There was a problem hiding this comment.
I recall this span being added because of blocks with custom SVG icons but I think it's not necessary anymore because we don't mix text and icons in the same button like we used to do and this is taken care of at the IconButton level.
youknowriad
approved these changes
Mar 1, 2018
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday I merged a fix to the IconButton component which adds a
text-indentfor when the component has text. This works because the SVG inside is not affected by text-indent.But the quick-shortcuts in the block appender wrap this icon with a
span, which is affected by the text-indent.I can look for other solutions that do not rely on text-indent, but simply removing this span entirely seems to have no negative effects. Why was it added? No CSS appears to target the element.
In master:
In this branch: