[WIP] Site Editor: Allow display of pattern blocks for Pages#53166
Closed
aaronrobertshaw wants to merge 1 commit intotrunkfrom
Closed
[WIP] Site Editor: Allow display of pattern blocks for Pages#53166aaronrobertshaw wants to merge 1 commit intotrunkfrom
aaronrobertshaw wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: -6 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Contributor
Author
|
FWIW, If I add |
Contributor
Author
|
Closing in favour of #53169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
NOTE: This isn't really a full solution but more a starting point for further debugging.
With this PR's tweak applied
wp:patternblocks in templates will display for Pages in the Site Editor. Unfortunately, template parts that referencewp:patternblocks provided via themes still appear to not renderWhat?
Allow display of
wp:patternblock when displaying a Page in the Site Editor.Why?
Without this, any Page using a Template containing a theme or core pattern will not render the pattern when visited via the Site Editor.
How?
Relocate the disabling of block editing to the HoC for the
editor.BlockEditfilter.Testing Instructions
Screenshots or screencast