Inserter: Fix unmodified default block replace, insert after selected#5296
Merged
Inserter: Fix unmodified default block replace, insert after selected#5296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5291
Regression introduced in #5137 (34b7e21)
This pull request seeks to resolve a bug in the Inserter component where the selectors are incorrectly returned as functions, not invoked to retrieve their intended values. This prevents the expected behavior in
InserterWithShortcutsfrom operating on the unmodified default block, because the value passed intowithDispatch'sonInsertBlockforselectedBlockis a function, not the block value itself.Testing instructions:
Repeat steps to reproduce from #5291, verifying that replacing the unmodified default block is replaced correctly.
A related issue not yet reported: Verify that inserting a block while another is selected will insert after the selected block.