Inserter: Remove margin from initial insertion point#5295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #5198 (comment)
Related: #5282
This pull request seeks to resolve a misalignment which occurs for the initial block in a block list, both for the top-level block list and in a nested context. From what I can discern from the styling, the negative margin is redundant with the negative relative positioning, and causes the first block to move upward in its entirety. The affected styling only impacts the very first insertion point, as others will not qualify for the child selector of
.editor-block-list__layout.Testing instructions:
Verify that when clicking in the writing prompt, the vertical positioning of the text aligns with where the writing prompt had been shown.