Missing return for DEWP code examples#52836
Closed
widoz wants to merge 1 commit intoWordPress:trunkfrom
widoz:patch-4
Closed
Missing return for DEWP code examples#52836widoz wants to merge 1 commit intoWordPress:trunkfrom widoz:patch-4
widoz wants to merge 1 commit intoWordPress:trunkfrom
widoz:patch-4
Conversation
The examples for `requestToExternal` and `requestToHandle` are missing to return `request`. Someone copy/paste the code might have dependencies missed because of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples for the Dependency Extraction Webpack Plugin for the functions
requestToExternalandrequestToHandleare missing to returnrequest. If someone copy/paste the code as a starting point they'll loose all other dependencies.