Conversation
…#52595) When determining if the block is groupable/ungroupable, we now avoid passing an undefined value which leads to a crash.
4 tasks
SiobhyB
approved these changes
Jul 14, 2023
Contributor
SiobhyB
left a comment
There was a problem hiding this comment.
LGTM! Performed a quick smoke test on both platforms, and confirmed the editor loads as expected with no crashes. Given that, and the manual testing outlined in the comments in wordpress-mobile/gutenberg-mobile#5962, I'm going ahead to approve. :) Thanks Carlos! 🙌
This was referenced Jul 14, 2023
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release 1.99.1 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5962
The changes incorporated in this beta fix can be checked in: rnmobile/1.99.0...rnmobile/release_1.99.1