Change pattern management title and text to avoid specifying pattern source incorrectly.#52568
Closed
Change pattern management title and text to avoid specifying pattern source incorrectly.#52568
Conversation
|
Size Change: +4 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
Contributor
|
Is "included" too ambiguous? 🤔 Maybe:
It might be simpler to have no heading... (#52570). |
Member
Author
Not sure about putting uneditable patterns with different sources under "My patterns"; it feels a bit confusing.
I like all of these! Happy to wait for @WordPress/gutenberg-design to chime in. |
|
Flaky tests detected in 9d2641a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5532375820
|
Contributor
|
"Additional patterns"? |
Member
|
Can we just have the title "Patterns" or "Additional Patterns". My preference is just "Patterns". This does not lock us into any terminology, and we can iterate later. I think this needs to have at least some heading for 6.3. cc @richtabor @annezazu @glendaviesnz @carolinan thoughts? |
Member
Author
Updated: I also changed the Read-only Pattern tooltip text to explain the situation a bit more; "Patterns bundled with themes or plugins cannot be edited." This is just a suggestion; happy to modify it as needed. 
|
Contributor
|
I think just "Patterns" is too vague considering the entire section of the Site Editor is for Patterns. I think we need to go with some sort of identifier. Perhaps "Additional" if we want concise. |
richtabor
reviewed
Jul 14, 2023
packages/edit-site/src/components/sidebar-navigation-screen-patterns/index.js
Outdated
Show resolved
Hide resolved
Member
Author
|
Seems like #52570 (comment) was already merged, removing the header. Still, I've updated it once more just in case. 
|
9f3f08c to
c36886e
Compare
richtabor
requested changes
Jul 14, 2023
packages/edit-site/src/components/sidebar-navigation-screen-patterns/index.js
Outdated
Show resolved
Hide resolved
3315ff2 to
8fda0b7
Compare
8fda0b7 to
b29ac2d
Compare
Member
Author
|
@richtabor @annezazu done |
jameskoster
approved these changes
Jul 18, 2023
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
Thank you, this looks good to go pending conflict resolution.
Contributor
|
Oh, I see that #52497 got merged, and that's likely the source of the conflict 😅 I don't have a strong feeling either way on this one. How about you @richtabor? |
Member
Author
|
This is redundant now since #52497 goes more in-depth. I suggest making further changes to the copy on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Re. #52498
Change wording for patterns in the editor to avoid mislabeling plugin patterns as theme patterns.
Screenshots or screencast