Add missing @emotion/react dep to block-editor#52475
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Jul 11, 2023
Merged
Add missing @emotion/react dep to block-editor#52475Mamaduka merged 1 commit intoWordPress:trunkfrom
@emotion/react dep to block-editor#52475Mamaduka merged 1 commit intoWordPress:trunkfrom
Conversation
PR WordPress#51545 added a dependency on `@emotion/styled`, which resulted in a transitive peer dependency on `@emotion/react`. We should satisfy that dependency ourself, just as we do in the components package.
scruffian
approved these changes
Jul 10, 2023
Contributor
scruffian
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add a missing dependency on
@emotion/reactfrom block-editor.Why?
PR #51545 added a dependency on
@emotion/styled, which resulted in a transitive peer dependency on@emotion/react. We should satisfy that dependency ourself, just as we do in the components package.How?
Add the missing dep.
Testing Instructions
Fixes #52474. See reproduction steps there.