Image block: Update lightbox animation tests#52290
Merged
artemiomorales merged 2 commits intotrunkfrom Jul 5, 2023
Merged
Conversation
ea0a860 to
a1cffd2
Compare
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
This was referenced Jul 4, 2023
aab2ee9 to
b97dbe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This adds tests to ensure the responsive image and enlarged image
srcattributes are loaded and unloaded as the lightbox is being opened.Why?
These test will help to ensure that the fade and zoom animations are working as expected.
How?
I've uploaded a new large image to use in the image block. I compare the
currentSrcattribute in the content against the responsive image, and theimageUploadedSrcagainst the enlarged image. I've also added a parameter theimageBlockUtilsupload function so that we can specify the new large image file.Testing Instructions
Run the tests using the following command:
npm run test:e2e:playwright -- image.spec.jsTesting Instructions for Keyboard
N/A