Blocks: Fix Reusable Blocks keyboard navigable (Introduce Disabled component)#5223
Merged
Blocks: Fix Reusable Blocks keyboard navigable (Introduce Disabled component)#5223
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where reusable blocks are keyboard navigable when not intended to be editable. The previous implementation used a
pointer-events: nonestyle to prevent a user from interacting with the reusable block, but it was easy to navigate into with keyboard thanks toWritingFlowbehaviors.The implementation here introduces a new reusable
Disabledcomponent which intends to manage all field disabling automatically.Refer to included README
Testing instructions:
Verify that you cannot edit a Reusable Block until selecting the parent block and choosing Edit, including when navigating between blocks using the keyboard.