Patterns: fix issue in 16.1 with wrong sync status set in Site Editor#52229
Merged
glendaviesnz merged 4 commits intorelease/16.1from Jul 3, 2023
Merged
Patterns: fix issue in 16.1 with wrong sync status set in Site Editor#52229glendaviesnz merged 4 commits intorelease/16.1from
glendaviesnz merged 4 commits intorelease/16.1from
Conversation
92 tasks
|
Size Change: +9 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 3, 2023
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for putting this one together @glendaviesnz 👍
I couldn't replicate the issue with new patterns created on the release/16.1 branch not showing in the correct sections in the site editor. I did encounter an old synced pattern from previous testing appearing in an incorrect location though.
After applying this PR:
✅ New and existing patterns are displayed in the correct sections in the site editor
✅ The issue preventing updating the patterns sync status in the post editor has been fixed
✅ After editing a pattern's sync status the pattern's location in the site editor is correctly updated
✅ All patterns were showing in the correct locations in the block editor
✅ Synced patterns appear in the quick inserter and under the correct tab in main inserter
✅ Unsynced patterns appear in custom patterns category in main inserter
* Fix phpunit failures * Add comment * Update comment with actual reason this fix works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
There was a bug with synced patterns added in the Site Editor having a deprecated sync status added, which causes them not to display in the post editor inserter.
Why?
The bug was fixed here, but this fix did not make it into the 16.1 release.
How?
Cherry picked the relevant commit and also added a check for the incorrect sync status to the reusable block selector.
This also includes the following php unit test fixes from trunk:
Testing Instructions
Screenshots or screencast
Before:
synced-before.mov
After:
synced-after.mov