Removed non-functional custom taxonomies meta boxes.#5221
Merged
jorgefilipecosta merged 1 commit intomasterfrom Feb 28, 2018
Merged
Conversation
aduth
requested changes
Feb 27, 2018
Member
aduth
left a comment
There was a problem hiding this comment.
This looks to be a good improvement, but I'm still seeing a meta box for my custom taxonomy:
Entirety of the plugin:
<?php
/**
* Plugin Name: Demo CPT
*/
add_action( 'init', function() {
register_post_type( 'book', [
'label' => 'Book',
'show_in_rest' => true,
'public' => true,
'show_ui' => true,
'supports' => [ 'title', 'editor' ],
] );
register_taxonomy( 'genre', 'book', [
'label' => __( 'Genre' ),
'rewrite' => array( 'slug' => 'genre' ),
'hierarchical' => false,
'show_ui' => true,
'show_in_rest' => true,
] );
} );98e824b to
ae93975
Compare
Member
Author
|
Hi @aduth, it looks like the way to build the meta boxes ids is different for non-hierarchical taxonomies I updated the code to handle this case. I also removed the 'categorydiv' and 'tagsdiv-post_tag' from the hardcoded list as this cases are handled by the new code. Thank you for catching this case 👍 |
aduth
approved these changes
Feb 28, 2018
lib/meta-box-partial-page.php
Outdated
Member
There was a problem hiding this comment.
Might be worth a mentioned to where this is generated in the base core code:
These meta boxes don't work at all, and the new editor already shows panel to allow the use of custom meta boxes. So showing this meta boxes is a bug.
ae93975 to
0165546
Compare
This was referenced Mar 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These meta boxes don't work at all, and the new editor already shows panels to allow the use of custom taxonomies. So showing this meta boxes is a bug.
How Has This Been Tested?
Add a custom taxonomy with a custom slug, verify a meta box with just the taxonomy title appear under Extended settings on the master branch, and does not appear on this branch.