Image block: fix aspect ratio sizing in the editor preview#52135
Open
Image block: fix aspect ratio sizing in the editor preview#52135
Conversation
|
Size Change: -5 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
Contributor
Contributor
|
After trying to advance this PR I don't think it's tackling the problem because:
... but most importantly: the problem is only when images are not coming from the media library which suggests there might be other issues. |
56d82d6 to
58c75df
Compare
58c75df to
48b1acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Fixes an issue where images that were smaller than the width of the page and only had an aspect ratio set were being scaled up in the editor.
Why?
Bug fix
How?
Played around with the
displayproperties of the image and resizable box container and removed 100%widthandheightin some cases.Testing Instructions
This is content for every possible combination of width/height/scale/aspect-ratio for the image block. Be sure to use an image that is smaller than the width of the page and one that doesn't have a 3:4 portrait aspect ratio (as that's the ratio set in the example).
Testing Instructions for Keyboard
Screenshots or screencast