Image block: Use built-in directive for mouseover event in lightbox#52067
Merged
artemiomorales merged 2 commits intotrunkfrom Jun 30, 2023
Merged
Image block: Use built-in directive for mouseover event in lightbox#52067artemiomorales merged 2 commits intotrunkfrom
artemiomorales merged 2 commits intotrunkfrom
Conversation
This was referenced Jun 28, 2023
|
Size Change: +500 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 06f5e8f1a5c0d6fab5f7b4042942f6f771e08d6f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5402548955
|
06f5e8f to
5771638
Compare
luisherranz
approved these changes
Jun 29, 2023
Member
luisherranz
left a comment
There was a problem hiding this comment.
It's slightly better to use mouseenter than mouseover for this use case. But other than that, you can merge it 🙂
Member
|
By the way, I rebased the code because GitHub was saying that there were conflicts and I wanted to take a look, but there are none, so 🤷♂️ |
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This changes the implementation of the preload image logic by moving it from a
data-wp-effectdirective to the built-indata-wp-on--mouseoverdirective.Why?
Brought up in the following code review.
In order to simplify code, we should be using built-in directives wherever possible.
How?
It replaces the directive and moves the preload function definition to
actions.Testing Instructions
Testing Instructions for Keyboard
N/A