Patterns: Update Manage Patterns to point to the Site Editor if available#51957
Closed
aaronrobertshaw wants to merge 2 commits intotrunkfrom
Closed
Patterns: Update Manage Patterns to point to the Site Editor if available#51957aaronrobertshaw wants to merge 2 commits intotrunkfrom
aaronrobertshaw wants to merge 2 commits intotrunkfrom
Conversation
92 tasks
|
Size Change: +152 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 39bcf6f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5421056805
|
Contributor
|
I like this change, but it only works for block themes.
|
Contributor
Author
Thanks @carolinan, I wasn't thinking clearly on this one. I'll iterate on it soon. |
Member
|
|
talldan
reviewed
Jun 27, 2023
Contributor
There was a problem hiding this comment.
May need to check how this works for roles that can't access the site editor. Maybe a fallback can be added.
7211b55 to
6824694
Compare
6824694 to
97ffc57
Compare
d5cacfa to
39bcf6f
Compare
Contributor
Author
|
I've updated this PR to link to the site editor only if it is accessible by the current user. If the general approach taken in 1621bc6 is passable, then I can clean up this PR on Monday. |
noisysocks
requested changes
Jul 7, 2023
| const [ url, setUrl ] = useState( defaultUrl ); | ||
|
|
||
| useEffect( () => { | ||
| window.fetch( patternsUrl ).then( ( response ) => { |
Member
There was a problem hiding this comment.
This is clever but I'm not a fan 😀
The problem is that the result isn't cached so the component will perform an AJAX request every time it mounts. If we use canUser then it will only perform the OPTIONS request once.
My preference would be to:
- Return
nullif user can’t access the Manage Patterns screen- Determine this using
canUser( 'read', 'global-styles' )
- Determine this using
- Link to the site editor if
getSettings().__unstableIsBlockBasedThemeis true
Contributor
Author
|
Closing this PR in favour of #52403 which avoids an uncached fetch call to check for user permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51944
Related:
What?
Updates "Manage Patterns" links to go to the library.
Note: This could be updated to simply direct to the root
/librarypath once it defaults to themy-patternscategory and falls back to the header template parts category if there aren't any patternsWhy?
With the new Library, there is a better location to direct users for managing their patterns.
How?
hrefattributes for the Manage Patterns linksTesting Instructions