Open
Conversation
|
Size Change: +107 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jun 26, 2023
| } ), | ||
| ] | ||
| : innerBlocks, | ||
| ungroup, |
Member
Author
There was a problem hiding this comment.
What might be better here is introduce a new key "unwrap" and only show these at the top of the block switcher. Then this also wouldn't show up as "Ungroup" in the Options dropdown
Member
|
I wasn't able to get this to successfully unquote: CleanShot.2023-06-29.at.12.12.11.mp4
|
Member
Author
|
@richtabor Apologies, should be fixed now. |
alexstine
reviewed
Jul 7, 2023
Contributor
alexstine
left a comment
There was a problem hiding this comment.
I find it hard to believe that users are confused by converting a quote block back to a paragraph block. Would it make sense to simply give the transform menu item a little more context? Unquote, convert to paragraph. Users...
Member
An alternative is to add a transform to "Paragraph", although the transform can technically contain any type of block within the Quote block (re InnerBlocks). That's the hang-up between "transform to paragraph" vs. "transform to unquote". That PR was merged, though I suspect this may be better suited — to have "Unquote" as an option, instead of "Paragraph". |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Restores the Unquote button (previously Unwrap), which was removed in #50385.
This is a quick and dirty PR, I'm open to suggestions.
Why?
Users cannot find how to unquote.
How?
Reuses the new ungroup API introduced in above PR.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast