Conversation
| size="12" | ||
| upperCase={ true } | ||
| > | ||
| { title || __( 'Navigation' ) } |
There was a problem hiding this comment.
Sneaky unrelated change?
|
I see the problem, but I'm not a fan of the "magic" numbers for pushing things around. Looks like the container for the ellipsis menu in the list view has a width of 24px, while the one next to the title is 36px. We could solve this by removing the padding on the ellipsis menu on the title. Something like |
|
Size Change: +167 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 31f7c05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5290981957
|
I'm reluctant to do this as I assume that the ellipsis position in the title area is the correct one. My preference is to make the lower section wider to also give more space for longer navigation items, but I take your point that magic values aren't good. Closing this for now. |
|
There's a padding that makes the lower section narrower (in |
|
I think @jameskoster has driven some of those design efforts, and might be better equipped to answer. |


What?
Aligns the ellipsis menus in Browse mode.
Why?
So it looks better.
How?
Add some negative margins to the list view so it can use more of the screen canvas. Unfortunately using a grid value isn't possible as the value we need is between grid values.
Testing Instructions
Testing Instructions for Keyboard
N/A. This is a visual change
Screenshots or screencast