User Patterns: only add core pattern categories to user taxonomy when they are used#51515
Closed
glendaviesnz wants to merge 2 commits intotry/adding-non-synced-pattern-to-reusable-block-cptfrom
Closed
Conversation
… user assigns it to a pattern
|
Size Change: +640 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Closing for now as it has been deciding not to include categories in the initial release of the unsynced patterns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Instead of adding all the core pattern categories to the new wp_pattern taxonomy, only add them as they are assigned.
Why?
In #51144 adding all the pattern categories to the user taxonomy and relying on them being there causes issues with users not being able to delete them, and locking down the taxonomy removes the flexibility of users being able to add their own terms
How?
Merges the user taxonomy with core patterns and adds a new term if a core category is selected and it has no taxonomy id
Testing Instructions
/wp-admin/edit-tags.php?taxonomy=wp_patternand delete any existing categories, and add one or more new categories that don't exist in core pattern categoriesCreate patternScreenshots or screencast
taxonomy.mp4