Skip to content

Add my_ prefix to callback function for registering post type#5150

Merged
youknowriad merged 2 commits intoWordPress:masterfrom
Shelob9:patch-3
Feb 28, 2018
Merged

Add my_ prefix to callback function for registering post type#5150
youknowriad merged 2 commits intoWordPress:masterfrom
Shelob9:patch-3

Conversation

@Shelob9
Copy link
Copy Markdown
Contributor

@Shelob9 Shelob9 commented Feb 19, 2018

Simple doc fix for #5149

Checklist:

  • [x ] My code is tested.
  • [x ] My code follows the WordPress code style.
  • [x ] My code has proper inline documentation.

@youknowriad
Copy link
Copy Markdown
Contributor

This is a duplicate of #4980 but I'd be inclined to merge this one if you can address @aduth 's comment #4980 (comment)

@Shelob9
Copy link
Copy Markdown
Contributor Author

Shelob9 commented Feb 20, 2018

@youknowriad I can edit. I replied to that comment with why I partially disagree. I will refesh my PR tomorrow.

@Shelob9
Copy link
Copy Markdown
Contributor Author

Shelob9 commented Feb 27, 2018

@youknowriad I updated based on #4980 (comment)

Copy link
Copy Markdown
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants