Add way for additional styles to be added to editor.#514
Closed
BE-Webdesign wants to merge 1 commit intomasterfrom
Closed
Add way for additional styles to be added to editor.#514BE-Webdesign wants to merge 1 commit intomasterfrom
BE-Webdesign wants to merge 1 commit intomasterfrom
Conversation
Fixes #422. Added an action so that someone could hook into where gutenberg styles are loaded and bring in an editor style of their own. I took this approach, as there is not a super clean way to mimic `add_editor_style()` without adding another global variable to WordPress, without PHP 5.3+, that I could find.
731c7cc to
6217408
Compare
Member
|
Sorry, I've been meaning to reply to this for a while, but I think we will need a more sophisticated approach here, potentially including styles for each block (defined by the block? by the theme? I'm not sure yet). See also: #422 (comment) |
Contributor
Author
|
Sounds good, so this will be tied in with the Server Side API for registering blocks? |
Member
Yes, though it's not yet clear to me how it will work. Something like a combination of |
This was referenced Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422. Added an action so that someone could hook into where
gutenberg styles are loaded and bring in an editor style of their own.
I took this approach, as there is not a super clean way to mimic
add_editor_style()without adding another global variable toWordPress, without PHP 5.3+, that I could find.