Size Change: +36 B (0%)

Total Size: 1.4 MB

_{compressed-size-action}

Flaky tests detected in 0a3227b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5046996714
📝 Reported issues:

• [Flaky Test] should delete the template after saving the reverted template #50783 in /test/e2e/specs/site-editor/template-revert.spec.js
• [Flaky Test] should show the original content after revert #47897 in /test/e2e/specs/site-editor/template-revert.spec.js

The problem here is that we deprecated the blocks prop of List View so now it expects a rootClientId from which to list all the child blocks.

Unfortunately in our scenario we don't have a root because these blocks (i.e. those from the wp_navigation menu) are at the top level with no parent nav block required.

@scruffian as you deprecated blocks what do you think about this? Maybe the effort to remove the Nav block isn't worth it? Other than providing a way to handle entity saving flow, is there anything else that the block provides that we need in the sidebar?

The reason for deprecating blocks is that we couldn't see a use case for it, but if we have one I think we should undeprecate it!

is there anything else that the block provides that we need in the sidebar?

I think the block is also being used to load the navigation menus.

I think the block is also being used to load the navigation menus.

Nope. We're doing that already. @talldan had some ideas in #49475 (comment)