Conversation
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2f8e2b0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5044814671
|
carolinan
approved these changes
May 22, 2023
Contributor
carolinan
left a comment
There was a problem hiding this comment.
I got a little confused by the new Library 😄 but that is unrelated, and the width looks correct now, thank you.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50815
What?
Fixes a style regression in #49910 where the "All template parts" screen was not taking up the full width available.
How?
As far as I can tell, this style only affects the "All templates" and "All template parts" screen in the Site Editor.
The reason the bug only reproduces in the "All template parts" screen (at least for the Twenty Twenty-Three theme) is that the template parts don't have these descriptions that push out the content width:
Testing Instructions
/wp-admin/site-editor.php?path=%2Fwp_template_part%2Fall. The white content card should take up the width available./wp-admin/site-editor.php?path=%2Fwp_template%2Fall. It should be the same as before.