Comments: Replace get_comments() with get_comments_number(). #50798
Merged
cbravobernal merged 1 commit intoWordPress:trunkfrom May 24, 2023
Merged
Comments: Replace get_comments() with get_comments_number(). #50798cbravobernal merged 1 commit intoWordPress:trunkfrom
cbravobernal merged 1 commit intoWordPress:trunkfrom
Conversation
alexstine
approved these changes
May 19, 2023
Contributor
alexstine
left a comment
There was a problem hiding this comment.
Code looks reasonable to me.
cbravobernal
approved these changes
May 24, 2023
Contributor
cbravobernal
left a comment
There was a problem hiding this comment.
Tested and work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR replaces a
get_comments()call and database query withget_comments_number().Why?
This approach has three advantages:
get_comments_number()uses a post property vs a separate database query.get_comments_number()is filtered, and it's much easier for plugins/themes to manipulate, vs having to usepre_get_commentsand jump through several hoops.Testing Instructions
Using the comments block under normal circumstances, no behavior changes should be observable.
To disabled comments and commenting on all content, one should now be able to:
Observe that prior to this PR, comments will still render using the comments block.
Closes #48975