Dimensions Panel: Fix resetting of axial spacing controls#50654
Merged
aaronrobertshaw merged 1 commit intotrunkfrom May 16, 2023
Merged
Dimensions Panel: Fix resetting of axial spacing controls#50654aaronrobertshaw merged 1 commit intotrunkfrom
aaronrobertshaw merged 1 commit intotrunkfrom
Conversation
3 tasks
kevin940726
approved these changes
May 16, 2023
Member
kevin940726
left a comment
There was a problem hiding this comment.
Detailed PR with clear testing instructions and screencasts! I'll just trust you on this! Code LGTM 👍
|
Size Change: +1 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ccb69b6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4989184275
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes regression introduced in #48070 which prevents resetting spacing controls for blocks with axial sides support only e.g. Button block padding.
Why?
Without this fix, any block specifying horizontal or vertical side support will crash when choosing to reset the relevant individual control in the Dimension panel.
How?
Skips filtering the values per side if there are no values.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-05-16.at.5.32.46.pm.mp4
Screen.Recording.2023-05-16.at.5.35.37.pm.mp4