E2E tests: try to fix flaky global styles revisions tests#50454
Merged
E2E tests: try to fix flaky global styles revisions tests#50454
Conversation
Ensuring we save any unsaved changes after then unsaved changes tests to avoid lingering unsaved changes. Updated a typo in a non-related e2e file
4 tasks
|
Size Change: -11 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
ramonjd
commented
May 9, 2023
| } ); | ||
|
|
||
| test( 'should disable toolbar butons when open', async ( { page } ) => { | ||
| test( 'should disable toolbar buttons when open', async ( { page } ) => { |
Member
|
Will this also fix #50419? :) |
Member
Author
Oooh! I think so. Thanks for reminding me and for the quick review @kevin940726 🙇 |
aaronrobertshaw
approved these changes
May 9, 2023
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Changes LGTM as well 🚢
After 10 runs, I didn't get any errors from the updated e2es.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Hopefully fixes #49708
Also hopefully resolves #50419
Updates e2e tests recently introduced in #50089 to:
Why?
The tests would fail every second run, complaining that it could not find the save button after changing the styles.
I'm not entirely sure why as the tests attempt to apply non-saved styles, which should trigger a dirty state.
Saving all changes appears to fix it.
Testing Instructions
Run this lots of times:
npm run test:e2e:playwright -- site-editor/user-global-styles-revisions.spec