Site editor: convert device type margin styles into non-shorthand syntax#50441
Merged
Site editor: convert device type margin styles into non-shorthand syntax#50441
Conversation
Contributor
Author
|
Actually, it looks like splitting the shorthand into non-shorthand props creates an issue where the top and bottom margins get overridden (which I guess proves the point of the warning). I pushed a change that should fix the issue, although I invite folks to take a closer look. |
|
Size Change: +27 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 457ab32. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4920369744
|
ciampo
commented
May 8, 2023
| ? `scale( ${ scale } )` | ||
| : props.style?.transform, | ||
| marginTop: | ||
| scale !== 1 |
Contributor
Author
There was a problem hiding this comment.
I think this could be the correct intention, since scale has a default value of 1 even when it's not passed as a prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As flagged by @Mamaduka , #47004 introduced a warning when switching device type in the site editor.
This PR refactors slightly the code in a way that avoids the error from being logged.
Why?
Mixing shorthand and non-shorthand properties can lead to unexpected bugs.
How?
De-duped the
marginshorthand property into the 4 individualmargin-*non-shorthand properties.Testing Instructions