Plugin: Ensure that view scripts are correctly registered for core blocks#50364
Merged
Plugin: Ensure that view scripts are correctly registered for core blocks#50364
Conversation
SantosGuillamot
approved these changes
May 5, 2023
Contributor
SantosGuillamot
left a comment
There was a problem hiding this comment.
I've tested it, and it seems to work fine with this fix. Thanks for the PR, Greg! 🙂
Mamaduka
approved these changes
May 5, 2023
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Fixes the navigation asset issue ✅
P.S. I don't like that we're getting a registry inside the loop, but the DRY approach here makes sense.
Member
Author
It's a singletone so it's just a reference you get through a function wrapper. |
Member
I know :) It's just a pattern I like to avoid. Personal taste 🍕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #50079.
Fixes #50211.
Why?
The view scripts registered in WordPress core for core blocks weren't correctly deregistered before registering again in the Gutenberg plugin. It was handled by a hook in the polyfill removed after we dropped support for WordPress 6.0.
How?
Ensure that all view scripts coming from core blocks are correctly deregistered just before the block gets unregistered.
Testing Instructions