wp-env: Fix redirect loop for instances on port 80 (and 443)#50282
Closed
Luehrsen wants to merge 2 commits intoWordPress:trunkfrom
Closed
wp-env: Fix redirect loop for instances on port 80 (and 443)#50282Luehrsen wants to merge 2 commits intoWordPress:trunkfrom
Luehrsen wants to merge 2 commits intoWordPress:trunkfrom
Conversation
ObliviousHarmony
requested changes
May 3, 2023
Contributor
ObliviousHarmony
left a comment
There was a problem hiding this comment.
Thanks for catching this and working on it!
I don't think the function signature has the correct type for port anymore. We are assuming that it's a string, but as per the validation done when parsing configuration files, it should always be number.
Could we:
- Update the
addOrReplacePortJSDoc forportto be{number}. - Update tests to pass a number instead of a string.
Contributor
Contributor
Author
|
@ObliviousHarmony Yeah, I think we can close this and work on #50300. Just make sure to credit appropriately and mention #49883 for better visibility! :) |
Contributor
|
Alright @Luehrsen, I've gone ahead and updated that PR's description to better reflect the primary fix it contains. Thanks! |
Member
|
Closing now that #50300 has landed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request introduces an exception within the
addOrReplacePortfunction, ensuring that if the specified port is either 80 or 443, the input remains unaltered.Why?
The modifications introduced in #49883 mandate the inclusion of port numbers in the constants
WP_TESTS_DOMAIN,WP_SITEURL, andWP_HOME. Unfortunately, there doesn't appear to be a configuration option to bypass the addition of these ports.As a result, this negatively impacts all
wp-envinstances operating on ports 80 or 443. Modern browsers automatically remove these default ports, which leads to a redirection loop in the frontend, rendering the site inaccessible to users