List View: Use block select button class for retaining colors when expanded or hovered#50155
Merged
andrewserong merged 1 commit intotrunkfrom Apr 28, 2023
Conversation
|
Size Change: +1 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for the quick review! |
Contributor
|
Y'all were too quick! Thank you 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A tiny follow-up PR to #48461 to swap out the
components-buttonclassname forblock-editor-list-view-block-select-buttonclassname.Why?
To be less dependent on the internal Button classnames.
Note: there are other usages in this CSS file for the
components-buttonclassname — I haven't removed them / swapped them out in this PR as those rules predate #48461. I'm happy to look into those separately, but it'll take a little longer as there are edge cases to figure out for those other usages as they are applied to more than one particular component / element (they're overridingBlockMoverUpButton,BlockMoverDownButtonandBlockSettingsDropdownbuttons so probably want to be tested carefully when refactored).How?
components-buttonclassname forblock-editor-list-view-block-select-buttonclassname.Testing Instructions
Screenshots or screencast