Skip to content

Revisions controller: fix author and date fields#50117

Merged
ramonjd merged 2 commits intotrunkfrom
fix/revisions-controller-return-revision-values
Apr 27, 2023
Merged

Revisions controller: fix author and date fields#50117
ramonjd merged 2 commits intotrunkfrom
fix/revisions-controller-return-revision-values

Conversation

@ramonjd
Copy link
Copy Markdown
Member

@ramonjd ramonjd commented Apr 27, 2023 •
edited
Loading

What, why, how?!

Correcting a mistake I made in #49974: we need the author, date and other details from the revision item not the parent

Testing Instructions

Run the tests!

npm run test:unit:php -- --filter Gutenberg_REST_Global_Styles_Revisions_Controller_Test

For bonus points, create another admin user and save some global styles changes.

Check that the revision items reflect the revision author's details. You can grab them in the console:

await wp.apiFetch( { url: `/index.php?rest_route=%2Fwp%2Fv2%2Fglobal-styles%2F${ wp.data.select('core').__experimentalGetCurrentGlobalStylesId() }%2Frevisions&_locale=user` } );

Screenshot 2023-04-27 at 3 13 02 pm

@ramonjd
Correcting a mistake I made in #49974: we need the author, date and o…
931affd 
…ther details from the revision item not the parent

Adding tests
@ramonjd ramonjd added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Apr 27, 2023
@ramonjd ramonjd requested a review from andrewserong April 27, 2023 05:15
@ramonjd ramonjd self-assigned this Apr 27, 2023
@ramonjd ramonjd requested a review from spacedmonkey as a code owner April 27, 2023 05:15
@ramonjd ramonjd mentioned this pull request Apr 27, 2023
Merged
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 27, 2023

Flaky tests detected in 931affd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4816248200
📝 Reported issues:

andrewserong
andrewserong approved these changes Apr 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the quick fix! How did we miss this earlier 😅

Before After
image image

LGTM! ✨

@andrewserong
Copy link
Copy Markdown
Contributor

andrewserong commented Apr 27, 2023

For bonus points, create another admin user and save some global styles changes.

I decided I'd go for the bonus points 😄

Multiple users is working nicely, too:

image

@ramonjd ramonjd enabled auto-merge (squash) April 27, 2023 05:57
@ramonjd
Copy link
Copy Markdown
Member Author

ramonjd commented Apr 27, 2023 •
edited
Loading

How did we miss this earlier

Thank you for the use of the first person plural, but it's okay in this case to say "How did YOU, @ramonjd, miss this earlier!?" 🤦 haha

Thanks for testing 🙇

@ramonjd ramonjd merged commit 3fc8957 into trunk Apr 27, 2023
@ramonjd ramonjd deleted the fix/revisions-controller-return-revision-values branch April 27, 2023 06:07
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewserong andrewserong andrewserong approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ramonjd ramonjd

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 15.8

Development

Successfully merging this pull request may close these issues.

2 participants

@ramonjd @andrewserong