Add chevrons to the templates and template parts in site editor.#50076
Merged
Add chevrons to the templates and template parts in site editor.#50076
Conversation
|
Size Change: +581 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Should the "Manage all" links also include a chevron? They technically open another level, it just seemed a bit odd to me. Happy to add it back if it's preferred. |
Contributor
|
Thanks for picking this up. In the interest of consistency, would it make sense to add the chevrons to drilldowns in the Navigation panel too?
I could go either way on this, but would lean towards including it, again just to be consistent.
|
Contributor
|
I pushed some adjustments:
|
Contributor
Author
|
Thanks for the updates. I'll add the chevron back in for the manage all links. I'll also add them in for the navigation screens since the chevron looks different there now. |
Contributor
Author
|
Actually scratch the navigation screen menus, I just realized that makes no sense because they don't work the same as other menus with sub menus. 👍 |
ramonjd
approved these changes
Apr 27, 2023
Member
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
Before
After
2023-04-27.10.09.40.mp4
ramonjd
reviewed
Apr 27, 2023
| { ! icon && children } | ||
| ) } | ||
| <FlexBlock>{ children }</FlexBlock> | ||
| { withChevron && ( |
Member
There was a problem hiding this comment.
Any possibility that this icon will be something other than a chevron? E.g., + or something?
Just asking. Looks easy enough to abstract should this ever be a use case in the future. 👍
Contributor
There was a problem hiding this comment.
I would think it's unlikely, but nothing is written in stone!
Contributor
Author
There was a problem hiding this comment.
It's possible, although in the existing code it was called this, so I matched it. Pretty straightforward to change in the future if needed.
Contributor
Ah, I meant Page Links in the Navigation panel, which do have the drilldown behavior: drilldowns.mp4 |
Contributor
Author
|
@jameskoster Sounds good. I am going to open a new PR shortly for the navigation items because it's going to be a bit more in-depth and will hold these changes up. |
This was referenced Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48591
What?
Add chevrons to templates and template parts in the site editor to indicate that these can be drilled down another level. This matches the top level.
Why?
To improve the consistency of interactions.
How?
Modify
SidebarNavigationItemto allow the inclusion of a chevron without the inclusion of an icon at the start of the item.Testing Instructions
Templatesand make sure all templates listed have a chevron on the right side.Template Partsand make sure all templates listed have a chevron on the right side.Screenshots or screencast
Before
After
