Merged
Conversation
|
Size Change: +10 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Contributor
|
I'll just add @alexstine as a reviewer here since there was recently some detailed work that landed in #48461 to refactor the ARIA props for the list view to ensure they're all optimised for screen readers. It'd be good to make sure this doesn't adversely affect anything that was recently updated there. From a quick skim, this change sounds good to me, though, since it's only updating at the very root / container of the list view 👍 |
alexstine
approved these changes
Apr 19, 2023
Contributor
alexstine
left a comment
There was a problem hiding this comment.
Yes, this should be fine.
Contributor
|
Thanks for the quick review, Alex! |
aristath
approved these changes
Apr 19, 2023
Contributor
Author
|
Thanks for the quick review and merge here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This adds an
aria-descriptionattribute to the list view.Why?
This came up as part of the accessibility review for the off canvas editor component, and the attribute was added there, but not ported back to the list view, so this PR takes care of that.
How?
Add a new prop (another one!) to the list view to populate the attribute, if its set.
Testing Instructions
Testing Instructions for Keyboard
This should be useful for screen readers, but I'm not totally sure how the aria-description attribute gets read.
Screenshots or screencast