Conversation
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Apr 10, 2023
Member
kevin940726
left a comment
There was a problem hiding this comment.
LGTM as long as it fixes the flakiness :). Thank you for handling it so fast! ❤️
|
Flaky tests detected in 87d6a46. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4654271583
|
Contributor
Author
|
I ran the E2E test four times and all passed with no problems, so I'll merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #49534
Thankfully, @kevin told me about it in this comment.
What?
This PR fixes the Playwright test instability reported in #49534 regarding column blocks.
Why?
Looking at the artifacts reported in trunk, it appears that the sidebar is not opened before manipulating the input element to change the number of columns. I guessed that perhaps we need to explicitly run
openDocumentSettingsSidebar().Testing Instructions
I would like to run the GitHub Action several times and see if the problem is fixed.