Skip to content

Docs: Fix e2e command typos#49669

Merged
alexstine merged 1 commit intoWordPress:trunkfrom
eduwass:patch-1
Apr 8, 2023
Merged

Docs: Fix e2e command typos#49669
alexstine merged 1 commit intoWordPress:trunkfrom
eduwass:patch-1

Conversation

@eduwass
Copy link
Copy Markdown
Contributor

@eduwass eduwass commented Apr 8, 2023

What?

Looks like there were 2 typos on some of the e2e commands in the test-e2e section

Why?

I noticed that the commands were not working when I copy/pasted them while I was going through the doc.

How?

Just replace npm run test-e2e with npm run test:e2e.

This should prevent future folks from getting confused.

Testing Instructions

  1. Go to https://developer.wordpress.org/block-editor/reference-guides/packages/packages-scripts/#test-e2e
  2. If you've been following the steps, and copied one of the commands, you will run into an error:
➜ npm run test-e2e FILE_NAME -- --puppeteer-interactive
npm ERR! Missing script: "test-e2e"
npm ERR! 
npm ERR! Did you mean this?
npm ERR!     npm run test:e2e # run the "test:e2e" package script
npm ERR! 
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

Testing Instructions for Keyboard

Not needed

@eduwass
Fix e2e command typos
b7a2176 
Some typos on the commands on the ### `test-e2e` section (replace `npm run test-e2e` with `npm run test:e2e` )
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @eduwass! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@eduwass eduwass marked this pull request as ready for review April 8, 2023 00:17
alexstine
alexstine approved these changes Apr 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduwass Thanks for the PR. Once upon a time, test-e2e was correct. Now it is test:e2e. Nice catch. 👍

@alexstine alexstine added the [Type] Developer Documentation Documentation for developers label Apr 8, 2023
@alexstine alexstine merged commit bdedc58 into WordPress:trunk Apr 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2023

Congratulations on your first merged pull request, @eduwass! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexstine alexstine alexstine approved these changes

@gziolo gziolo Awaiting requested review from gziolo gziolo is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher ryanwelcher is a code owner

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Gutenberg 15.6

Development

Successfully merging this pull request may close these issues.

2 participants

@eduwass @alexstine