Border Panel: Move global styles forcing of split borders to relevant panel's onChange#49603
Merged
aaronrobertshaw merged 4 commits intotrunkfrom Apr 6, 2023
Merged
Conversation
1 task
youknowriad
reviewed
Apr 5, 2023
|
Size Change: +2.86 kB (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6aadf4c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4626962564
|
Also prevents attempting to encode flat color for border object that is undefined.
youknowriad
approved these changes
Apr 6, 2023
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for making these updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #49594
What?
Prior to #48636, only the Global Styles would force a split definition of border styles. This PR moves that logic to the Global Styles' border panel's
onChangethereby restoring the original behaviour of the individual block border supports.Why?
Forcing split borders results in bloated CSS as every longhand style is added individually to a block's inline styles.
How?
onBorderChangein the genericBorderPanelto theonChangeof the Global Styles'BorderPanel.Testing Instructions
Screenshots or screencast