refactor(blob): type url parameter as optional#49201
Merged
jorgefilipecosta merged 1 commit intoWordPress:trunkfrom Sep 12, 2023
Merged
refactor(blob): type url parameter as optional#49201jorgefilipecosta merged 1 commit intoWordPress:trunkfrom
jorgefilipecosta merged 1 commit intoWordPress:trunkfrom
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @johnhooks! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
6d85b8a to
24fa8be
Compare
24fa8be to
43cbdd3
Compare
jorgefilipecosta
approved these changes
Sep 12, 2023
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
The change looks good to me. The code of isBlobURL supports undefined, and in normal usage undefined can be passed so it seems the typescript types should reflect that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Type the
urlparameter of@wordpress/blobfunctionisBlobUrlas possiblyundefined.Why?
In common usage, the
urlparameter of the@wordpress/blobfunctions could beundefined. Though it is not typed as such, causing type errors when passed possibly undefined values in TypeScript.Example of passing
urlas possiblyundefinedincore/audio:gutenberg/packages/block-library/src/audio/edit.js
Lines 61 to 74 in 9612e1c
How?
Type the
urlparameter asstring|undefined. I choose this over making it optional, as instring=, because passing no value isn't how the functions are used.Testing Instructions
The current tests should be sufficient.