Conversation
If you paste in a codepen URL into the editor, it embeds, but is not full width. This PR fixes that.
|
Are there negative side effects of adding a 100% width to this? Like does this affect the width of a twitter embed in a weird way? |
|
Taking a look. I think we should have a document that lists URLs to test with when making embed style changes, I'll compile a list in another PR :) |
|
As far as I can see, this just forces the Sandbox body width to the width of the container, which is what we want. I think as part of this change we should add a README.md in the sandbox component that shows how to test that any changes are working. The tests I perform are... Embed the following:
Create a custom html block with the following content: This tests that html is written into the sandbox correctly in all cases, and that sites that do responsive resizes (e.g. tumblr) don't mess up when put into a small iframe that is also trying to resize. Does that sound reasonable as part of this change? |
|
Thank you! |
| @@ -0,0 +1,14 @@ | |||
| This component is used to embed embeds! | |||
There was a problem hiding this comment.
Well, more precisely, this component has nothing to do with embeds specifically, it just provides an isolated environment for any arbitrary HTML via iframes.
Addresses #4916 (review). Thanks Andrew!
Addresses #4916 (review). Thanks Andrew!
If you paste in a codepen URL into the editor, it embeds, but is not full width. This PR fixes that.
Before:
After: