Skip to content

HTML API: Pull in updates from Core#48812

Merged
dmsnell merged 1 commit intotrunkfrom
update/html-api-updates-from-core
Mar 9, 2023
Merged

HTML API: Pull in updates from Core#48812
dmsnell merged 1 commit intotrunkfrom
update/html-api-updates-from-core

Conversation

@dmsnell
Copy link
Copy Markdown
Member

@dmsnell dmsnell commented Mar 6, 2023

What?

Blessed update pulling in updates to the HTML Tag Processor from Core into Gutenberg.

Related: WordPress/wordpress-develop@455b1e8

Why?

This process is being explored post 6.2 merge now that the HTML API development is occurring in Core.

Testing

Unit tests should pass, code should be audited. These changes should reflect the files in Core. They were generated by copying those files directly and then running git a -p to include everything but the class rename.

For the updates that landed here in Gutenberg head of Core (assuming those changes migrate into Core once the window for changes opens) I followed this procedure:

  • Temporarily revert 0ff570f
  • Copy the Tag Processor for Core's repo
  • git add -p to include only the updates
  • Commit in a temporary branch: note the commit hash
  • Reset to trunk
  • git cherry-pick the commit hash from the temporary branch

There were no merge conflicts this way, and I luckily didn't have to manually handle the addition of has_bookmark in Gutenberg.

@dmsnell dmsnell requested review from adamziel and ockham March 6, 2023 22:24
@dmsnell dmsnell requested a review from spacedmonkey as a code owner March 6, 2023 22:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2023

Flaky tests detected in 17ef976f7057b46b22efe80272ef7481f3054a77.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4368732969
📝 Reported issues:

@dmsnell
Copy link
Copy Markdown
Member Author

dmsnell commented Mar 6, 2023

@ockham @ockham seems like we could use a few canary tests in the compat layer to ensure basic operation (e.g. we don't introduce syntax errors on these backports)

I think that with the work done lately to run PHP tests against a matrix of versions we might be able to do this once and have it check the 6.2 and 6.3 compat classe.

I'll try to add them and explore

@dmsnell dmsnell force-pushed the update/html-api-updates-from-core branch from fe3f85e to 15822ed Compare March 8, 2023 00:21
@dmsnell
Copy link
Copy Markdown
Member Author

dmsnell commented Mar 8, 2023

Updated from fe3f85e to 15822ed to also pull in the documentation changes. Followed the same method mentioned in the description.

Copy link
Copy Markdown
Contributor

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dmsnell !

@dmsnell dmsnell force-pushed the update/html-api-updates-from-core branch 4 times, most recently from 11c2dfc to 38f2d56 Compare March 9, 2023 03:35
@dmsnell dmsnell force-pushed the update/html-api-updates-from-core branch from 38f2d56 to c6d69e1 Compare March 9, 2023 16:06
@dmsnell dmsnell merged commit c6d69e1 into trunk Mar 9, 2023
@dmsnell dmsnell deleted the update/html-api-updates-from-core branch March 9, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants