Skip to content

Adds anchor block support to List Items#48758

Merged
talldan merged 1 commit intotrunkfrom
unknown repository
Aug 7, 2024
Merged

Adds anchor block support to List Items#48758
talldan merged 1 commit intotrunkfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 5, 2023

Adds anchor block support to List Items, in it's block.json, and updated the docs accordingly. This couldn't be done before, as the List Item wasn't a child block back then.

Fixes #29838

@ghost ghost requested a review from mtias March 5, 2023 12:01
@ghost ghost self-assigned this Mar 5, 2023
@ghost ghost added the [Type] Enhancement A suggestion for improvement. label Mar 5, 2023
@skorasaurus skorasaurus added the [Block] List Affects the List Block label Aug 18, 2023
@ejnwebmaster
Copy link
Copy Markdown

ejnwebmaster commented Feb 29, 2024

I'm new this, but this seems so close to being complete. Is there a way to bring this to closure? I appreciate the hard work by all, truly.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 29, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tomdevisser <thomasdevisser@git.wordpress.org>
Co-authored-by: ejnwebmaster <ejnwebmaster@git.wordpress.org>
Co-authored-by: mtias <matveb@git.wordpress.org>
Co-authored-by: adamwoodnz <adamwood@git.wordpress.org>
Co-authored-by: pbiron <pbiron@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@talldan talldan requested a review from ndiego as a code owner August 7, 2024 03:11
talldan
talldan approved these changes Aug 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the PR and it's still working well for me. Thanks for the contribution!

@talldan talldan mentioned this pull request Aug 7, 2024
Closed
@talldan talldan merged commit 9a55d5f into WordPress:trunk Aug 7, 2024
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@mtias mtias Awaiting requested review from mtias

@ndiego ndiego Awaiting requested review from ndiego

Assignees

No one assigned

Labels

[Block] List Affects the List Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 19.0

Development

Successfully merging this pull request may close these issues.

Add UI for setting ID (anchors) on list items (<li>)

3 participants

@ejnwebmaster @talldan @skorasaurus