Skip to content

WP_Theme_JSON: sync indirect properties changes from core#48646

Merged
oandregal merged 1 commit intotrunkfrom
update/theme-json-indirect-properties
Mar 2, 2023
Merged

WP_Theme_JSON: sync indirect properties changes from core#48646
oandregal merged 1 commit intotrunkfrom
update/theme-json-indirect-properties

Conversation

@oandregal
Copy link
Copy Markdown
Member

@oandregal oandregal commented Mar 1, 2023 •
edited
Loading

What?

This PR syncs the Gutenberg class with the corresponding WordPress core changes.

Why?

By being in sync, future backport processes will be much easier.

Context:

How?

Copy the code from core to Gutenberg.

@oandregal oandregal requested a review from spacedmonkey as a code owner March 1, 2023 16:08
@oandregal oandregal added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Mar 1, 2023
@oandregal oandregal requested a review from hellofromtonya March 1, 2023 16:10
@oandregal oandregal mentioned this pull request Mar 1, 2023
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2023

Flaky tests detected in 23d8bce.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4305527875
📝 Reported issues:

andrewserong
andrewserong approved these changes Mar 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting the backport @oandregal! 😄

This is still testing well for me (added define( 'DISALLOW_UNFILTERED_HTML', true ); locally, then tested that content and wide size, and block spacing values save in global styles) 👍

In case anyone's comparing this PR against the diff in WordPress/wordpress-develop#3742, this PR correctly uses the * @since 6.2.0 line in core, rather than the * @since 6.1.2 line from that PR's diff.

LGTM! ✨

@peterwilsoncc
Copy link
Copy Markdown
Contributor

peterwilsoncc commented Mar 1, 2023

this PR correctly uses the * @since 6.2.0 line in core, rather than the * @since 6.1.2 line from that PR's diff.

I think that was altered in a follow up commit so that core used the correct version. It seems 6.2 will be released first.

@andrewserong
Copy link
Copy Markdown
Contributor

andrewserong commented Mar 2, 2023

I think that was altered in a follow up commit so that core used the correct version. It seems 6.2 will be released first.

Thanks for confirming!

@oandregal oandregal merged commit 8473276 into trunk Mar 2, 2023
@oandregal oandregal deleted the update/theme-json-indirect-properties branch March 2, 2023 08:23
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewserong andrewserong andrewserong approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@mmtr mmtr Awaiting requested review from mmtr

@tellthemachines tellthemachines Awaiting requested review from tellthemachines tellthemachines is a code owner

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc

@hellofromtonya hellofromtonya Awaiting requested review from hellofromtonya

Assignees

No one assigned

Labels

Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core

Projects

None yet

Milestone

Gutenberg 15.4

Development

Successfully merging this pull request may close these issues.

3 participants

@oandregal @peterwilsoncc @andrewserong