Framework: Per-block script bundles, server enqueues#4841
Closed
Framework: Per-block script bundles, server enqueues#4841
Conversation
This was referenced Feb 5, 2018
Member
|
I grouped all issues that we need to take into consideration when working on this PR under one column in the Extensibility project. |
This was referenced Feb 5, 2018
3 tasks
This was referenced Mar 20, 2018
|
I'm continuing work on this functionality. I haven't opened a pull request from my fork's branch to this branch yet. I'll do so once the work is nearing completion. The diff can be viewed at the below link: update/build-individual-blocks...kanishkdudeja:update/build-individual-blocks |
7 tasks
5 tasks
Member
Author
|
It's unlikely this could be salvaged with changes made to master in the meantime. Going to close in favor of other pull requests, e.g. 6087 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2751, #4514, #2756
This pull request seeks to explore creating individual script bundles for each core block, reverting core registration changes introduced in #4514 while still separating core block registration from the underlying block APIs. The intent here is to work toward core block registration reflecting recommended block enqueueing, also laying a path for server-side block registration for core blocks (#2751) and eventually asynchronous block loading (#2756, #4500 (comment)).
Work-in-progress: The Webpack configuration has been updated to target each block, though could use some refinements particularly in how the global properties are assigned, and filenames of the build distributables generated. Only the paragraph block has been ported to being enqueued by the server-side
editor_scripthandle property. Tests need to be fixed to register core blocks.