Merged
Conversation
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 298ada7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229362387
|
Member
|
@kevin940726, I see the same failure reported inline for the code. |
Member
Author
|
😢 So sad... |
c0e00ba to
78725bd
Compare
Contributor
|
Staring at the e2e tests spinning icon to see if they pass 🙀 |
Member
Author
|
Okay, this seems to work now. I use a different approach by asserting the |
Contributor
|
@kevin940726 good finding! So, to my understanding, it was a timing issue? |
Member
Author
t-hamano
approved these changes
Feb 21, 2023
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I ran the test just one more time, just to be sure 🙂
eae3392 to
298ada7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Close #48067.
Why?
Fix the flakiness of the a11y test.
How?
Playwright runs too fast before the modal can run some of the code for constrained tabbing. We explicitly wait for
aria-labelto be sure thattabindexhas been updated. I'm not sure why it's only failing on Webkit though. This is not an ideal solution but I couldn't figure out a better one at the time. Let's merge this first to unblock other PRs, we can figure out a better solution in another PR.I ran this locally 100 times and they all passed.
Testing Instructions
CI should pass.