Editor: Add ifPostTypeSupports higher-order component (try conditional render HoC pattern)#4815
Closed
Editor: Add ifPostTypeSupports higher-order component (try conditional render HoC pattern)#4815
Conversation
Member
|
@jorgefilipecosta opened a similar PR. See #4812. In general both implementation are similar 😃 |
Member
Author
|
Well then... 😅 I think we could probably combine the two branches:
Can take a look tomorrow, or if @jorgefilipecosta wants to go ahead, by all means. |
Member
|
Thank you @aduth, I will merge both PR's 👍 |
Member
Yes, that would be nice. This one answers also some questions I had in the other PR :) |
Member
Author
|
Closing in favor of #4812. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to implement a new
ifPostTypeSupportshigher-order component which serves in place of the existingPostTypeSupportCheckand attempts to explore a new generalized pattern for conditional component rendering.Example Before:
Example After:
Implementation notes:
The thinking behind the naming convention is that we could create higher-order component-libraries with the following expectations:
ifSomeConditionwithSomePropsTesting instructions:
Verify that there are no regressions in the behavior of post-type-conditional elements:
commentsortrackbackssupports)thumbnailsupport)excerptsupport)post-formatssupport)authorsupport)page-attributessupport)revisionssupport)