Block Editor: Add 'Justify' option to alignment controls#48146
Closed
danielbachhuber wants to merge 1 commit into
Closed
Block Editor: Add 'Justify' option to alignment controls#48146danielbachhuber wants to merge 1 commit into
danielbachhuber wants to merge 1 commit into
Conversation
This was referenced Feb 16, 2023
|
Size Change: +83 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Feb 16, 2023
ellatrix
left a comment
Member
There was a problem hiding this comment.
To me this looks good. Would be good if someone signed off on the icon addition.
Member
|
Are there any open issues that can be closed with this? |
Member
|
Also would be great if a global style option could be added, not sure how hard that would be. |
|
Flaky tests detected in 654cf3e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4198085888
|
Member
Author
@ellatrix I think it's just #27300 and #8450
I don't see text alignment as a global style...
Do you mean "it would be great to add text alignment as a global style" generally? |
Member
Author
|
Punting on this PR initially in favor of #48202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a 'Align text justify' option to alignment controls:
Why?
'Justify' as a text alignment option is a long-requested Gutenberg enhancement: #8450
Many plugins have added 'Justify' on their own but it's much better for Gutenberg to simply support it.
Fixes #27300
Fixes #8450
How?
This PR registers a new 'Align text justify' option alongside the existing alignment options.
Testing Instructions
Testing Instructions for Keyboard
N/A