Skip to content

Verse: Adopt border supports#48021

Merged
aaronrobertshaw merged 1 commit intotrunkfrom
add/border-supports-to-verse
Feb 15, 2023
Merged

Verse: Adopt border supports#48021
aaronrobertshaw merged 1 commit intotrunkfrom
add/border-supports-to-verse

Conversation

@aaronrobertshaw
Copy link
Copy Markdown
Contributor

@aaronrobertshaw aaronrobertshaw commented Feb 13, 2023

What?

  • Adopts border support for the Verse block

Why?

  • Another small step towards consistent design tooling across all blocks.

How?

  • Adopts all border supports for the Verse block
  • No border controls are displayed by default

Testing Instructions

  1. Navigate to the Site Editor > Global Styles > Style Book
  2. Select the Verse block under the Text tab
  3. Within the Global Styles sidebar, select Border
  4. Trial adding different border configurations and ensure they are displayed correctly in the preview
  5. Save the Global Styles and switch to editing a post in the Block Editor
  6. Add a Verse block and confirm it receives the border you set in Global Styles
  7. Save the post and confirm border is applied on the front end
  8. Back in the editor, select the Verse block and reconfigure its border via the Block Inspector
  9. The new border should override the Global Styles you set
  10. Save and confirm the new custom border is displayed correctly on the frontend

Screenshots or screencast

Screen.Recording.2023-02-13.at.9.42.56.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Verse Affects the Verse block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Feb 13, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Feb 13, 2023
@aaronrobertshaw aaronrobertshaw mentioned this pull request Feb 13, 2023
Open
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2023 •
edited
Loading

Flaky tests detected in 46e1dfb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4179162112
📝 Reported issues:

glendaviesnz
glendaviesnz approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
✅ Border color and radius applied to block in global styles were applied to block in post editor and frontend
✅ Border color and radius were optional and not shown by default in post editor block inspection panel
✅ When optional color/radius controls were selected and set in post editor the changes overrode the global style settings in editor and frontend

@aaronrobertshaw aaronrobertshaw force-pushed the add/border-supports-to-verse branch from 58b3501 to 46e1dfb Compare February 14, 2023 23:54
@aaronrobertshaw aaronrobertshaw merged commit f8d4ddf into trunk Feb 15, 2023
@aaronrobertshaw aaronrobertshaw deleted the add/border-supports-to-verse branch February 15, 2023 01:35
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 15, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@femkreations femkreations mentioned this pull request Jul 12, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glendaviesnz glendaviesnz glendaviesnz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels

[Block] Verse Affects the Verse block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 15.2

Development

Successfully merging this pull request may close these issues.

3 participants

@aaronrobertshaw @glendaviesnz @femkreations