Post Editor: Fix lingering visual editor classes#4781
Merged
Conversation
83d98aa to
1fc0142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced in #4661
This pull request seeks to resolve an issue where a few styles remained which had been applied to the
.editor-visual-editorclass scope, which was renamed.edit-post-visual-editorin #4661. This affects both the Subhead block and EditorWarning components.Testing instructions:
Verify that the invalid block warning is styled as expected (per "After" screenshot above). For example, try modifying attributes of a block in
post-content.jsdemo content to cause the block to become invalid.