Skip to content

feat: Set up Android Flipper integration#47618

Merged
dcalhoun merged 1 commit intotrunkfrom
feat/integrate-flipper-debugger-for-android
Feb 1, 2023
Merged

feat: Set up Android Flipper integration#47618
dcalhoun merged 1 commit intotrunkfrom
feat/integrate-flipper-debugger-for-android

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

What?

Set up Flipper debugger integration for the Android
platform. Note: this does not enable support for iOS, as this project relies
upon use_frameworks!, which is currently unsupported by Flipper.

Supersedes #32822.

Why?

Access additional Flipper debugger features, e.g. inspection of network request,
native layout elements, etc.

How?

Add Flipper initialization code.

Testing Instructions

  1. npm run native start:reset
  2. npm run native android
  3. Launch the Flipper debugger.
  4. Select the "Gutenberg" application in the drop-down menu in the left sidebar.
  5. Verify that you are able to enable additional plugins, e.g. Network, Layout.

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

@dcalhoun dcalhoun added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Feature New feature to highlight in changelogs. labels Jan 31, 2023
@dcalhoun dcalhoun self-assigned this Jan 31, 2023
@dcalhoun dcalhoun requested a review from derekblank January 31, 2023 14:56
Add Flipper initialization code to access additional Flipper features,
e.g. Network, Layout, etc.
@dcalhoun dcalhoun force-pushed the feat/integrate-flipper-debugger-for-android branch from 087aed2 to 98db6d3 Compare January 31, 2023 15:44
@dcalhoun dcalhoun added the Mobile App - Automation Label used to initiate Mobile App PR Automation label Jan 31, 2023
Copy link
Copy Markdown
Member

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After ensuring that the filepath to my local Android SDK was correct in Flipper settings, I was able to successfully connect to Flipper and test.

LGTM, nice work! 🚀

@dcalhoun dcalhoun merged commit 24cc63d into trunk Feb 1, 2023
@dcalhoun dcalhoun deleted the feat/integrate-flipper-debugger-for-android branch February 1, 2023 12:29
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Feature New feature to highlight in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants