Size Change: 0 B

Total Size: 1.31 MB

_{compressed-size-action}

I'm a bit confused about the existing error:

● Front End Performance › Time To First Byte (TTFB)

Evaluation failed: TypeError: Cannot read properties of undefined (reading 'startTime')

 at ../../__puppeteer_evaluation_script__:17:36
 at ExecutionContext._evaluateInternal (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:273:13)
 at ExecutionContext.evaluate (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:140:12)
 at getLoadingDurations (specs/performance/utils.js:86:9)
 at Object.<anonymous> (specs/performance/front-end-classic-theme.test.js:41:32)

There's no startTime imported by utils.js now, though there was one in my first commit. I wonder what I'm missing here 🤔 @kevin940726 @mikachan I'd benefit from a second pair of eyes!

There's no startTime imported by utils.js now, though there was one in my first commit.

Hmm, I think this error is referring to the startTime on line 104. Although I'm not sure why it's undefined here, as I assume this has been working fine previously.

Reading this, perhaps we should be wrapping paintTimings in JSON.stringify? Something like this: JSON.stringify( performance.getEntriesByName( 'first-paint' ) )[ 0 ].startTime and JSON.stringify( performance.getEntriesByName( 'first-contentful-paint' ) )[ 0 ].startTime.

I believe this is because we run getLoadingDurations() as soon as the page is loaded, which doesn't necessarily mean it's painted. While we only need the TTFB metrics, the util collects all kinds of different metrics in the same function. I think it's not an issue in other tests because we usually delay running this function until the pages are fully painted.

Maybe it's time to refactor this util to make it more resilient. Using PerformanceObserver with buffered: true might be a good solution for this issue?

Closing this for now, it doesn't seem the right approach.